raiden-contracts

raiden-contracts copied to clipboard

Implement a feature to check that a Solidity source did not change

2

We [have to](https://github.com/raiden-network/raiden-contracts/issues/1208#issuecomment-537490029) get `make compile_contracts` fail when the source of SecretRegistry changes. For that we need a command that compares Soldity sources against an entry in `contracts.json`. `contracts.json` contains...

pirapira

A feature to skip compilation of SecretRegistry

2

When we upgrade the Solidity compiler #1155 but want to keep an old compilation of SecretRegistry, we need a feature where contracts except SecretRegistry is compiled. This issue keeps track...

pirapira

Currently `TokenNetwork` contracts can be deprecated, but not `TokenNetworkRegistry` contracts. This means that we have no way of disallowing creating new token networks after the registry has been deployed (besides...

palango

Currently the `withdraw_delay` in the `UserDeposit` contract is hardcoded to `100` blocks. This is inconvenient in tests as waiting 100 blocks unnecessarily slows them down. Whether we want to take...

ulope

Functions are not sorted by external, public, internal, private.

1

Functions are not sorted by external, public, internal, private. This makes it harder to reason about the code

pirapira

you often use abbreviations, which may not be so obvious to the reader (for example ms instead of Monitoring service (MonitoringService:15, msc_address (UserDeposit.sol:13)

pirapira

Try Brownie code coverage tool

5

* does it run? * how much time does it consume? * does it show something interesting?

pirapira

Add a test to deploy a contract of CONTRACTS_VERSION even when ``data`` and ``data_CONTRACTS_VERSION`` contain different sources

1

This test prevents https://github.com/raiden-network/raiden-contracts/issues/1312 in the future.

pirapira

run make verify_contracts on CONTRACTS_VERSION in the CI builds

1

This issue keeps track of changing the CI so it fails when the Solidity sources and `contracts.json` do not match in `data_CONTRACTS_VERSION`. When `data_CONTRACTS_VERSION/contracts.json` and `data_CONTRACTS_VERSION/sources` do not match, the...

pirapira

Utilize the solidity SMT Checker for our contracts

2

The slides by @axic are here: https://drive.google.com/file/d/1AniKaHdhmDG3nkKP9jbyuE_-pjmFCl4n/view In order to use the SMTChecker we need to add the following pragma: ```solidity pragma experimentalSMTChecker; ``` We should use it in order...

LefterisJP