raiden-contracts

raiden-contracts copied to clipboard

Assess code splitting for core contracts (libraries, proxies etc.)

3

(In work issue) **tl;dr** Code splitting with libraries and/or proxies could make the code cleaner. Feature requested for a while. Latest discussion: https://github.com/raiden-network/raiden-contracts/pull/213#issuecomment-410789290 ## History Initial contracts from the `raiden`...

loredanacirstea

Improve type safety by wrapping value types in structs

9

Currently `uint256` is used for timeouts, chain_id, token amounts, channel identifiers, nonces, block_numbers, and expirations. On most cases these are completely incompatible and mixing the values is a bug, and...

hackaugusto

Ideally, we should use modifiers for function input checks

2

Using modifiers is also recommended by the official Solidity docs: https://solidity.readthedocs.io/en/v0.4.24/miscellaneous.html?highlight=modifier#tips-and-tricks https://solidity.readthedocs.io/en/v0.4.24/common-patterns.html?highlight=modifier#restricting-access Using modifiers clarifies in what contract state can a function be called and makes it easier to verify...

loredanacirstea

Rethink data structures and assess if they are optimal: - clear code - gas cost efficient This should happen after all agreed upon features are implemented. Functionality first, then optimizations.

loredanacirstea

Change TokenNetwork to TokenNetworkERC20

2

We will have a `TokenNetwork` library with the core code and multiple contracts that use `TokenNetwork` but implement the specified token interface. E.g. `TokenNetworkERC20`

loredanacirstea

Right now, the BPs submitted during settlement have to match the hashed balance proofs submitted during closeChannel and updateNonClosingBalanceProof. The downside of this is that you need to store all...

karlb

Front-running opportunity in OneToN.sol

4

When an honest service calls `OneToN.claim()`, another malicious service (maybe collaborating with the owner of the claimed fund) can try to call the same function with another IOU, and deplete...

pirapira

Are we checking the checksum of checksum address?

1

Especially when the addresses are given as command line arguments.

pirapira

Test failure cases of MS contract

1

This issue keeps track of listing and implementing failing cases of MS contract.

pirapira

Test unhappy cases of Deposit contract

1

ServiceRegistry stores the registration deposits in separate Deposit contract (defined in ServiceRegistry.sol). This issue keeps track of testing unhappy code paths of the Deposit contract.

pirapira