raiden-contracts icon indicating copy to clipboard operation
raiden-contracts copied to clipboard

Test failure cases of MS contract

Open pirapira opened this issue 6 years ago • 1 comments

This issue keeps track of listing and implementing failing cases of MS contract.

pirapira avatar Feb 14 '19 16:02 pirapira

  • [x] running constructor with token address being zero
  • [ ] running constructor with service registry address being zero https://github.com/raiden-network/raiden-contracts/pull/1334
  • [x] running constructor with token address without code https://github.com/raiden-network/raiden-contracts/pull/1335
  • [x] running constructor with service_registry_address without code https://github.com/raiden-network/raiden-contracts/pull/1336
  • [ ] running constructor with udc_address without code https://github.com/raiden-network/raiden-contracts/pull/1337
  • [ ] running constructor with token_network_registry without code
  • [ ] updateReward(): "Unknown TokenNetwork"
  • [ ] updateReward(): "Bad reward proof"
  • [ ] updateReward(): "stale nonce"
  • [ ] monitor() --> updateReward() said reentrancy
  • [ ] monitor() --> updateReward() "Unknown TokenNetwork"
  • [ ] monitor() --> updateReward() "Bad reward proof"
  • [ ] monitor() --> updateReward() "stale nonce"
  • [ ] monitor() --> "not allowed to monitor"
    • because "channel not closed"
    • because "too low settle block number"
    • because "firstBlockAllowedToMonitor" not reached yet
  • [ ] monitor() --> updateNonClosingBalanceProof() fails.
  • [ ] firstBlockAllowedToMonitor(): "maliciously big settle timeout"
  • [ ] firstBlockAllowedToMonitor(): "maliciously big closed_at_block"
  • [ ] claimReward(): when token_network_address is a malicous address
  • [ ] claimReward(): "too early channel state"
  • [ ] claimReward(): "channel not settled yet"
  • [ ] claimReward(): "reward_sender is zero"
  • [ ] claimReward(): "UDC did not transfer"
  • [ ] more

pirapira avatar Oct 29 '19 09:10 pirapira