rahulrv1980

I think this is likely because of a repeated field in your schema. We don't have any, so, I did not do much testing around that. There were existing unit...

I think I have a fix. Let me know if you are ready to try it

Mike, please try the code in the branch : https://github.com/rahulrv1980/elephant-bird/tree/RepeatedFieldFix. Also, if it does not work, could you write a test case for the failure and I can look to...

Could you provide a test case with your message definition with the failures. There are existing unit tests for ProtobufStructObjectInspector. You could modify an existing one or better still, add...

How are you validating that the change caused the performance degradation? Did the ProtobufStructObjectInspector without my change work at higher performance (Not sure how the old version worked at all)....

Got it. Could you try adding this equals() method? @Override public boolean equals(Object o) { if (!(o instanceof ProtobufStructObjectInspector)) { return false; } ProtobufStructObjectInspector that = (ProtobufStructObjectInspector)o; return (descriptor.equals(that.descriptor) &&...

I have added your fix + the equals() method change to the branch at https://github.com/rahulrv1980/elephant-bird/tree/RepeatedFieldFix. Let me know if it works

I suppose the descriptor alone may be sufficient. But, it is strange that builder.equals(that.builder) is returning false. Could you share what the builder objects are?

Could you dump the different builder objects?

@mikebern ping?