Rahul Gaur
Rahul Gaur
The test I added probably broke a few things but we can fix them later this week.
Working on it now....
There is accidental modding happening somewhere. Here's the result of modding alpha in grad alpha  The curve should be smooth and not jump like that towards the end.
Since there will only ever be two types of bounce integrals, I think we should have two modes for bi: one corresponding to 1/sqrt(1-lambda B) and the other corresponding to...
I have added fixes to the bounce_average_test. Now, the only thing that we need to fix are: - The discontinuity of the grid (and the coefficients) - The sqrt(1-lambda B)...
When I run pytest -k test_bounce_averaged_drifts, I get the following error ``` tests/test_bounce_integral.py:43: in @np.vectorize(signature="(m)->()") E TypeError: vectorize.__init__() missing 1 required positional argument: 'pyfunc' ``` Is the signature correct? When...
I checked the zeta that goes into compute_theta_coords and it is continuous. However, the theta_PEST theta comes out of compute_theta_coords is discontinuous. However, that shouldn't be a problem because the...
override_grid=False fixes the discontinuity. Only thing left to do is case wise quadrature for sqrt(1-lambda B) and 1/sqrt(1-lambda B) singularities. I think the best way to implement this to add...
The test fails on my copy of desc for a different reason ``` ImportError while importing test module '/home/rgaur/DESC/tests/test_grid.py'. E ImportError: cannot import name 'meshgrid_expand' from 'desc.grid' (/home/rgaur/DESC/desc/grid.py) ``` I...
|B| does not look like it's normalized because if it were 1/lambda should go from 1. I don't know how the normalization can affect the output. I'll probably revert back...