keras-resnet icon indicating copy to clipboard operation
keras-resnet copied to clipboard

Published 20 hours ago • verified publisher icon raghakot

Submit Pull request to keras-contrib?

Open ahundt opened this issue 7 years ago • 6 comments

Keras has created a new official keras-contrib repository where they will accept a broader range of contributions than mainline keras, for eventual inclusion in mainline if it becomes widely used. Would you consider submitting your implementation?

https://github.com/farizrahman4u/keras-contrib

ahundt avatar Feb 02 '17 17:02 ahundt

Sure. Where should the tests go? would resnet.py go into applications?

raghakot avatar Feb 07 '17 18:02 raghakot

I think tests would go in: https://github.com/farizrahman4u/keras-contrib/tree/master/tests/keras_contrib

As for model contributions I'm opening up an issue on that topic now.

ahundt avatar Feb 07 '17 22:02 ahundt

And now to come full circle, https://github.com/farizrahman4u/keras-contrib/issues/15 is the relevant github issue I created.

ahundt avatar Feb 07 '17 22:02 ahundt

The directory structure is the same as keras, so it looks like you're right about the applications folder: https://github.com/fchollet/keras/blob/master/keras/applications/resnet50.py

ahundt avatar Feb 08 '17 01:02 ahundt

The updated implementation is now merged in keras-contrib. Could you consider adding a pointer to there in the readme of this repository? I've incorporated fairly substantial updates over there. https://github.com/farizrahman4u/keras-contrib/blob/master/keras_contrib/applications/resnet.py

ahundt avatar Oct 17 '17 16:10 ahundt

Looks very good. I honestly don't have time to maintain this repo anymore. I will simply redirect users to your repo for latest changes.

raghakot avatar Oct 17 '17 18:10 raghakot