Ragav Venkatesan

Results 8 comments of Ragav Venkatesan

> So, I was waiting on you folks for some feedback on the initial code. I am working on tests this weekend, I can prioritize for next release since you...

So, @Borda I think the metric is implemented. I working on unit test (taking suggestions for tests now). I have tested this on actual model training and seems like it...

Addressed all comments @SkafteNicki Anything on tests?

> I don't think there is an easy implementation available anywhere. For reference, here is the hacky way that tensorflow tests a similar loss in their pull-request for this loss....

> This is a better idea. I will write tests comparing against this. Thanks.

Hi @Borda I apologize, went on vacation. Getting back to this and prioritizing this now.

@Borda can you make a push into the source branch again please? I am getting a merge conflict when I push. Thanks.

> Hi @ragavvenkatesan, looks like a good addition. Do you wanna try to tackle this one and send a PR? :] Sure, what are the perks of being a contributor...