Rafał Pitoń

Results 305 comments of Rafał Pitoń

I've meant accessing `request.json()` second time. `extract_data_from_request` really only does validation on data. On sidenote, wouldn't it make it more sense to pass data to `Extension.request_started`?

TBH it's going to be less problematic than suggested change, which would require us to change signature for `context_value` callable to have parity between default behavior for context creation and...

IMHO this is another issue in the "we need better extension system" saga, not "we need to put data in default context" ;) Adding tracing to context creation would be...

Turns out this would be useful for root value resolver in our GraphQL proxy implementation, so I'll give it a try.

Yup, we'll need to document this feature, maybe adding section about query batching to existing wsgi middleware docs.

Hi @jacobmischka, thanks for interest! This feature is currently on hold, but we we will eventually return to it and get it implemented. > Without query batching in some way...

@dacevedo12 remember that QueryBatching is a mechanism used to save time sending multiple queries in single HTTP request. It doesn't affect query executor so it makes no difference if you...

@process0 I think we could have feature flag to enable query batching, but first I want to get #855 merged

@process0 question about federation doesn't seem accurate. Federated servers implement `_entities` query that receives list of type:id pairs of items it should return to federation gateway, so there's no N+1...

We could use type definitions from graphql-core and and run extra checks on our side at type's definition time.