Rafał Pitoń
Rafał Pitoń
Hi! There's better way to enable this behavior than through decorator. Every input field and argument has `out_name` attribute that can be set to custom value. Eg. if you set...
Left some extra notes but those are tiny bits and nothing blocking - but code needs to be formatted with black to pass tests.
Note that I'll be out of office for next two weeks. But I'll work on 0.16 release when I'm back. If you **really** need to use 0.16, I've made 0.16.0b1...
Is this to run blocking IO like api calls or database queries?
GraphQL extensions shouldn't manage database connection. This should happen outside of Ariadne, eg. in Starlette's startup and shutdown methods.
This should be implemented as ASGI middleware and not GraphQL extension. GraphQL extensions should be used for things that really really are associated with query execution process itself, and nothing...
I'm not arguing against making extensions system async, I can see a point in that (which is why issue is left open). I'm arguing against using them for managing database...
Looks like `build_and_extend_schema` is not adding extension's type directives to extended type. Our schema extension logic that lives in `build_and_extend_schema` could be, well, extended to handle this.
At situations like this the first question to be asked is what _you_ would expect to happen here. Your opinion will be as good as anyone's :) Personally I'm thinking...
@patrys we know that because our implementation is port of apollo-server's ;)