Rafał Harabień

Results 108 comments of Rafał Harabień

If I read it correctly the compiler says that you are missing a generic parameter near `Partition` struct. This struct is not part of `fatfs` crate so I don't think...

Is this a valid FAT filesystem or a manually crafted data with a goal to crash the lib? I can see multiple places where overflow could happen and I believe...

I added `IntoStorage` trait to simplify usage with std and keep compatibility with old version, so people don't have to wrap IO into `StdIoWrapper`. But I was never happy with...

There are no plans for exFAT support in the near future. From what I know exFAT is very different from FAT12/16/32 - it has additional structures and different memory layout....

What about returning inner disk object from `unmount()` function so you can use it to recreate the `FileSystem` object when mounting again? I don't like idea of having `FileSystem` object...

Exposing API for flushing fsinfo sector and clearing dirty bit would be possible but it wouldn't be enough. What if someone tries to use filesystem when unmounted? What about mounting...

@MabezDev Is your disk statically allocated too? Couldn't you just use a statically allocated Option so when unmounted it would be set to empty?

I was thinking about returning something similar to `std::io::IntoInnerError`. What do you think? What worries me that if flush fails you get the wrapping (filesystem) object back (see `BufWriter`) and...

@ischeinkman Well, technically it would be possible to add such API. But after feature from this issue is implemented (Add method to get `DirEntry` from a path) you could just...

By `get_file_from_path` you mean this issue (Add method to get `DirEntry` from a path)? You will be able to lookup directory entry even if file is opened. If you need...