Rafael Mendonça França

Results 515 comments of Rafael Mendonça França

> @rafaelfranca would testing/staging environment for rubygems.org help you building trust to new process? For sure!

Actually, I thin I can just rename rails to something else in my fork and release on those new names. Them I can just yank all those new gems I'm...

I was able to setup the release for Rails. Here are the results of my tests: https://www.npmjs.com/package/omg-actioncable https://www.npmjs.com/package/omg-activestorage https://www.npmjs.com/package/omg-actiontext https://rubygems.org/gems/omg-rails/versions/8.0.0.alpha3 https://rubygems.org/gems/omg-railties/versions/8.0.0.alpha3 https://rubygems.org/gems/omg-actiontext/versions/8.0.0.alpha3 https://rubygems.org/gems/omg-actionmailbox/versions/8.0.0.alpha3 https://rubygems.org/gems/omg-activestorage/versions/8.0.0.alpha3 https://rubygems.org/gems/omg-actionmailer/versions/8.0.0.alpha3 https://rubygems.org/gems/omg-actioncable/versions/8.0.0.alpha3 https://rubygems.org/gems/omg-activejob/versions/8.0.0.alpha3 https://rubygems.org/gems/omg-activerecord/versions/8.0.0.alpha3 https://rubygems.org/gems/omg-actionview/versions/8.0.0.alpha3 https://rubygems.org/gems/omg-activesupport/versions/8.0.0.alpha3...

Tests are here https://github.com/rails/rails/blob/main/actionpack/test/controller/live_stream_test.rb. There are tests for copying the locals. But note that this test class is overriding the method you changed, so we need to remove the override.

Test are failing: ``` ActionController::LiveStreamTest#test_exception_callback_when_committed: --   | fatal: No live threads left. Deadlock? ```

Looking the documentation it seems this is by design. Why do you need this to be instrumented in the memory store?

https://github.com/rails/rails/commit/85688a689edabdd65b3d50b8e336aef9d1d7e954

Maybe to avoid overhead. But yeah, I could also not figure out. Regardless, this change should update the documentation as well.

Yes. I think we should. See https://github.com/rails/rails/pull/50008