Rafael Mendonça França comments

Results 515 comments of


                                            Rafael Mendonça França

Modifying AST and generating source code

Closing this since it is more a question, but the answer is yes, you can use a visitor to modify the AST, or even build a new AST. And they...

`commit_transaction_on_non_local_return` deprecation is misleading

@skipkayhil's reading is correct. Setting the flag would always print a deprecation in 7.1, meaning that that behavior would change in 7.2 with no escape hatch. That was already the...

4.3.0: Spring-enabled binstub crashes if ENV contains non-ASCII value

Fixed by #738

Set the worker process count automatically with WEB_CONCURRENCY=auto

Would concurrent-ruby be required at that point? The rails application would only require it when the `config/applicaton.rb` file is required. I think inlining the implementation could be a better idea...

Use `available_processor_count` as worker numbers if `WEB_CONCURRENCY` is set to `"auto"`

Yes!

Use `available_processor_count` as worker numbers if `WEB_CONCURRENCY` is set to `"auto"`

It doesn't take in consideration cpu quotas, also JRuby, but yeah, that might be enough. The way the PR was implemented doesn't force the dependency, but if you have use...

Support for Net::HTTPPaymentRequired

Can you please send the PR?

Disallow TOTP reuse

If I got this correctly, yes, this would break the Rails release. As we release gems in sequence, most of the time the OTP code didn't change yet between the...

Disallow TOTP reuse

I don't think you need to convince us. We would like to use it. I just not sure if we can right now. Rails release is complex, it has a...

Disallow TOTP reuse

I'm started to test the trusted publisher with the thor gem. I was able to make it work. https://github.com/rails/thor/blob/main/.github/workflows/release.yml https://github.com/rails/thor/actions/runs/10619918898/job/29438536653 The annoying part is more a GitHub limitation than a...