Cameron Radmore
Cameron Radmore
Lightbox is using`×` instead of `x` which is why screen readers are reading it as times
They're still evaluating criteria to check if wet-boew is compliant so it probably isn't 100% compliant at this time
Are there any plans for the properties that call Sync methods? Ex: The Title property in WebDriver executes a driver command inside of a getter instead of providing a method....
Updated and rebased @duboisp
if the order of the list matters then it is best practice to use numbers. (Numbered lists are known as ordered lists and bullet lists are known as unordered lists...
I think this would fail WCAG 2.0 guideline 1.3.1 [Technique H48](https://www.w3.org/WAI/WCAG20/Techniques/html/H48.html) as one of the tests that needs to pass is: ``` Check that content that has the visual appearance...
> @radmorecameron thanks for opening a PR! Would you mind telling us more on the background for this PR in particular? At the moment we do not have open issues...
Hi @daine would you want me to update this PR to also run the linter in another job [whenever tests are ran through GitHub actions](https://github.com/cds-snc/gcds-components/blob/main/.github/workflows/run-tests.yml) ? Thanks, Cameron
It should now run the linter with the test pipeline now
This seems to have been broken in wet-boew 4.0.71 (from November 2023). Edit: it seems like this PR might be the culprit https://github.com/wet-boew/wet-boew/pull/9703 if I undo the changes from that...