John Kreitlow

Results 34 comments of John Kreitlow

This would be great to have built-in. As a workaround, this can be handled by adding a matcher extension: ```ts // playwright.config.ts expect.extend({ async hasAttribute(recieved: Locator, attribute: string) { const...

For combobox, this is expected behavior: > While `combobox` is implemented in very similar ways as `select`, the `value` attribute on `fast-option` and other `option`-like elements is ignored in favor...

@atmgrifter00 With regards to the specification for combobox, this is expected behavior as described in my previous comment. Having separate values for combobox options can conflict with the ability to...

This also affects `::slotted()` and `::part()`.

I'm not familiar with how React rendering handles nested elements, but my first guess is that it could be a pacing condition where the select is created, then the options...

Hello there, I wrote a custom formatter that does this. Formatter: https://github.com/jwplayer/jw-design-library/blob/master/scripts/formatters/font-face.js Dictionary: https://github.com/jwplayer/jw-design-library/blob/master/dictionary/properties/font/font-face.yaml We're doing a bunch of other weird things (like converting the TTF to WOFF and WOFF2...

This PR should probably be split into parts to be merged into the `master` and `archives/fast-components` branches.

@EisenbergEffect yes, and I have a solution I've been experimenting with that does exactly that.

I think there's more to this than just supporting `e`, since there's a specific structure to exponential notation: > The decimal exponential literal is specified by the following format: `beN`;...