Radim Krčmář

Results 42 comments of Radim Krčmář

> I don't think it says what to do in the spec aside from explaining what the flag means. I didn't search profusely, though. I was relying on the search...

The pull request also expands the status to bits(64) and explicitly copies the fields, so I can drop 4 patches. I will rebase when it lands and add 2 patches...

I rebased on top of https://github.com/riscv/sail-riscv/pull/652/ and noticed a bug in it, so this isn't just a cleanup anymore, but introduces a software observable change.

The patch fixing it is https://github.com/riscv/sail-riscv/pull/683/commits/dc3e3c0852f0945686e29e889dafb6b01fc295e5. In short, mstatush contains 0b01 in SXL and UXL fields instead of required 0b00. To fix it quickly, we could replace the SXL/UXL bits...

> They're also supposed to be 0 if the corresponding privilege mode isn't implemented Good point. I didn't really want to change any software-visible behavior in this PR, so I'll...

I noticed that I didn't commit my last change, so the reset patch was only correct if mstatus was pre-initialized with zeros... It makes no difference, because we have to...

> LGTM but I think this could be split into several basically independent PRs which would make it a lot easier to review (and give us nicer history). E.g. Will...

> Yeah I mean it doesn't really have a concept of saying "this PR depends on this other PR, so don't show that one". Apparently some source hosting systems do...

Most of the patches got merged through other pull requests, and the remaining two weren't that important, so I just let it rot... I did a rebase, and dropped the...