Ankit Jain

Results 267 comments of Ankit Jain

> And that test is expected to fail but the dotnet test process is expected to return exit code 0. Hm no, I'm wrong about that. I'll investigate.

TODO: - [ ] Collect logs from the xunit test run in the outer templates test

I could not figure out what to change for the description in these two: ```diff diff --git a/src/Aspire.ProjectTemplates/templates/aspire-starter/.template.config/localize/templatestrings.tr.json b/src/Aspire.ProjectTemplates/templates/aspire-starter/.template.config/localize/templatestring> index 737c96ed81..1791ad243e 100644 --- a/src/Aspire.ProjectTemplates/templates/aspire-starter/.template.config/localize/templatestrings.tr.json +++ b/src/Aspire.ProjectTemplates/templates/aspire-starter/.template.config/localize/templatestrings.tr.json @@ -1,6 +1,6 @@...

ah, I see how I missed them. I'll fix that. Also, some have names like `.NET Aspire App-Host`, which I changed to `.NET Aspire 9-App-Host`. And there is: ```diff diff...

/backport to release/9.0-rc1

Combined the remaining tasks in https://github.com/dotnet/aspire/issues/2689 and https://github.com/dotnet/aspire/issues/6076 into https://github.com/dotnet/aspire/issues/9576 . Closing.

note to self: message is likely getting missed because it arrives before we start waiting for text. solution: WaitforResources, and then start waiting. And use eventing to set up waiting...

Update: This is incorrect as the all the messages get replayed ~~note to self: message is likely getting missed because it arrives before we start waiting for text. solution: WaitforResources,...