Radek Pietruszewski
Radek Pietruszewski
Thanks @zhenkaGo -- I'll close this PR as the work continues in https://github.com/Nozbe/WatermelonDB/pull/1799
@tomkennedy22 I can't answer the problem off the top of my head, but my Loki usage is all here: https://github.com/Nozbe/WatermelonDB/blob/master/src/adapters/lokijs/worker/DatabaseDriver.js (and generally in the lokijs) catalog - maybe that helps...
Thanks! This seems incorrect, I believe simdjson will use `generic` implementation fine on 32-bit https://github.com/simdjson/simdjson/blob/ec0b48b7722112e4fa005e557aa0531756c1718a/include/simdjson/portability.h#L89-L90 but I must admit that I haven't checked this, and I haven't benchmarked on Android....
@fbmal7 Thanks for insight on V8 parser, very interesting!
@fbmal7 Thanks for the answer! I suspected that this would be your decision, and if I were in Hermes team's shoes, I'd probably also be reluctant to take on simdjson...
@tmikov I have considered it, but I don't think I can achieve much of a perf win from simdjson via JSI, access to Hermes-internal API seems essential
@martyfitzer-ids I don't know for sure, but don't worry about it -- it was broken before your changes. Seems like a Visual Studio update on GitHub's side broke it. I...
thanks for the TS improvement!
@skam22 Thank you for your contribution! I'm seeing some issues, and I'd like to have this feature finished and shipped, so I took the liberty to add more commits to...
Yes, sorry for staying quiet about it. Yes, I'm planning to work on this likely in August.