Radosław Miernik comments

Results 151 comments of


                                            Radosław Miernik

Integration with flowtype

I've prepared a basic typing, enough for my needs. If anyone would test and/or finish it, I'd polish it and make a PR for flow-typed. ```js declare class Baobab extends...

Mongodb client.topology is undefined

@denihs, @Grubba27 I've made a small change in the PR and tested it again on a single node replica set - everything works fine. Then I tested it on a...

When `The Mongo server and the Meteor query disagree on how many documents match your query.`, socket is broken.

What exactly happens when this "disagree error" occurs? Is it the same as throwing an error in the publication? Or does it hang the server, i.e., the user cannot continue?...

Improved `oplogV2V1Converter` implementation.

@Grubba27 The first couple of MongoDB errors (error code 48) are rather _normal_, as they suggest that there's some other MongoDB instance and/or port is taken (weird, but OK). But...

Cursor.observe 'changed' callback is fired twice and with invalid documents - changed(newDocument, oldDocument)

I looked into it, and it has nothing to do with the `ObjectId`. The problem is still there even if you make it as simple as `Links.update(id, {$set: {params: {d:...

Cursor.observe 'changed' callback is fired twice and with invalid documents - changed(newDocument, oldDocument)

@wolasss It's all good. I already have the fix ready, and the `ObjectId` is correctly preserved (it's not casted to a plain object).

Fixed `MongoConnection._onFailover` hook (fixes #12118).

@Grubba27 I've rebased this PR as well, but Travis tests are still failing with tons of `undefined`s. What do you think, can we merge it?

Inconsistency in Minimongo after Collection.update($set, content) where content is not a primitive value

This should be fixed on 2.8 beta via #12107.

Stop using globals in the meteor code base

With all of the globals removed, we could simplify the [`@types/meteor`](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/meteor) as well. Right now most of them have to be duplicated to cover the global and non-global versions, and...

External db changes to document nested objects aren't sent over subscription to client

@igal1c0de4n I've checked it now, and #12107 does **not** solve the issue, but #12116 does. Surprisingly enough, the current implementation (i.e., the one that is available in the 2.8-beta.0 version)...