Andrew Murray

Results 761 comments of Andrew Murray

I've created https://github.com/python-pillow/Pillow/pull/9032, to move forward with part of this at least.

test_image_getdata_putdata.py seems like a mouthful. How about just test_image_data.py?

> Moved all of the getdata and putdata tests to the same file (because test_getdata_putdata doesn't fit in either individual file) Sorry, I've just realised what this meant. In main,...

[As I've said](https://github.com/python-pillow/Pillow/pull/8017#issuecomment-2081325752), my opinion is that this change isn't needed. If others think it is though, feel free to outvote me.

> **edit:** made a patch for my build to pass without adding the `lcms2` depenency, [here's the gist](https://gist.github.com/cleebp/ad3b6fe9cbe92b9cbe1aa2fbb103d5fa) This is the same as proposed fix #8196

> Looks like we're waiting on resolution to a [Docs build](https://github.com/python-pillow/Pillow/pull/8196#issuecomment-2204211887) [issue](https://github.com/python-pillow/Pillow/pull/8197#pullrequestreview-2158010309) in order to merge the [fix](https://github.com/python-pillow/Pillow/pull/8196)([s](https://github.com/python-pillow/Pillow/pull/8197)). I'm not entirely sure about the priority level of building docs without...

The opinion of Pillow users should always be relevant. Thanks for your review - just waiting for approval from another member of the core team.

Hi. Pillow 10.3.0 was the first release to signal that we provide type hints ourselves, so that would be the reason for the change. Even though you're unable to provide...

`from PIL import Image` has always been a module, and `from PIL import Image; Image.Image` has always been a class. It sounds like the presence of Pillow type hints just...

It sounds like your code was along the lines of ```python from PIL import Image im: Image = Image.new("RGB", (1, 1)) im.convert("L") ``` If so, then that type hint were...