nodewatch icon indicating copy to clipboard operation
nodewatch copied to clipboard

Node downtime being calculated incorrectly

Open hyperthunk opened this issue 14 years ago • 8 comments

All update events in dxkit_world_server seem to incorrectly set the elapsed downtime to the total elapsed up and down timespan.

hyperthunk avatar Apr 14 '11 10:04 hyperthunk

test_image_getdata_putdata.py seems like a mouthful. How about just test_image_data.py?

radarhere avatar Apr 28 '24 03:04 radarhere

sure

Yay295 avatar Apr 28 '24 03:04 Yay295

Moved all of the getdata and putdata tests to the same file (because test_getdata_putdata doesn't fit in either individual file)

Sorry, I've just realised what this meant. In main, we currently have test_image_getdata.py and test_image_putdata.py, and here you've merged them together into a single file because you'd like to find a new home for a test from test_image.py / #7209, and you don't think a roundtrip test belongs in either file.

I think test_image_putdata.py already has roundtrip tests, using both getdata() and putdata(). https://github.com/python-pillow/Pillow/blob/c250a44177ac1e82d300aef702d5c2feef15fd03/Tests/test_image_putdata.py#L60-L68

radarhere avatar Apr 28 '24 04:04 radarhere

I'd say those should be in the combined file for the same reason. Though I suppose I shouldn't have added putdata to those function names.

Yay295 avatar Apr 28 '24 05:04 Yay295

Cleaned up the tests a bit more.

Yay295 avatar Apr 28 '24 05:04 Yay295

rebased, multiple times because I didn't check it locally and kept missing something when resolving the conflict

Yay295 avatar May 15 '24 17:05 Yay295

What is currently blocking this from being merged?

Yay295 avatar Oct 17 '24 16:10 Yay295

As I've said, my opinion is that this change isn't needed. If others think it is though, feel free to outvote me.

radarhere avatar Oct 17 '24 20:10 radarhere