nodewatch
nodewatch copied to clipboard
Node downtime being calculated incorrectly
All update events in dxkit_world_server seem to incorrectly set the elapsed downtime to the total elapsed up and down timespan.
test_image_getdata_putdata.py seems like a mouthful. How about just test_image_data.py?
sure
Moved all of the getdata and putdata tests to the same file (because test_getdata_putdata doesn't fit in either individual file)
Sorry, I've just realised what this meant. In main, we currently have test_image_getdata.py and test_image_putdata.py, and here you've merged them together into a single file because you'd like to find a new home for a test from test_image.py / #7209, and you don't think a roundtrip test belongs in either file.
I think test_image_putdata.py already has roundtrip tests, using both getdata() and putdata().
https://github.com/python-pillow/Pillow/blob/c250a44177ac1e82d300aef702d5c2feef15fd03/Tests/test_image_putdata.py#L60-L68
I'd say those should be in the combined file for the same reason. Though I suppose I shouldn't have added putdata to those function names.
Cleaned up the tests a bit more.
rebased, multiple times because I didn't check it locally and kept missing something when resolving the conflict
What is currently blocking this from being merged?
As I've said, my opinion is that this change isn't needed. If others think it is though, feel free to outvote me.