Arnout Engelen

Results 679 comments of Arnout Engelen

> I look at authentication [protocol](http://nginx.org/en/docs/mail/ngx_mail_auth_http_module.html#protocol) and I see that the case for "no auth is required" is mentioned there. Does existing approach fail to satisfy your requirements? Are you...

I have now checked that the implementation makes sense to me, and tested it using `nginx-tests` with https://github.com/nginx/nginx-tests/pull/14 . I think it's now ready for review.

looks like this was in `RemotingSpec: must allow other system to connect even if it's not there at first`

> Maybe we can stop 1.0.0-nightly build? I think we should keep that around until we officially EOL the 1.0.x branch - which is something we might want to discuss...

This is not for merge, right? Might be good to mark it 'draft'

> The link to report a security issue on https://github.com/apache/hertzbeat/issues/new/choose is not ASF standard practice. It is my understanding that all security issues relating to ASF projects and podlings need...

> > Yes, we should disable the option to report security issues through GitHub Private Vulnerability Reporting, because it currently does not leave the correct audit log. Before disabling GitHub...

Which API are you thinking of here? Where do we have timers that support cancellation?

Gotcha, indeed `scheduleOnce` already returns a `Cancellable` which has a `cancel()` and an `isCancelled`, but doesn't allow 'listening' to the cancellation. It doesn't look super easy to provide a way...

> [scala/scala#10972](https://github.com/scala/scala/pull/10972) , submitted to scala Awesome that you have proposed this improvement upstream, thanks! I see two motivations for this change: the performance improvement, and the fact that the...