motif icon indicating copy to clipboard operation
motif copied to clipboard

Move default parameters to config file

Open rabitt opened this issue 9 years ago • 3 comments

Set the default parameters in a config.py file (e.g., avoid this 0.5 here). An example of configuration in msaf.

rabitt avatar Oct 07 '16 19:10 rabitt

@urinieto what other defaults did you see besides the 0.5 that you think need to be abstracted out?

rabitt avatar Oct 10 '16 17:10 rabitt

Ideally, any default parameter (like this, this, or this). But I understand how tedious this can become. You may know better than anyone which parameters are the most important ones to play around with melody extraction.

urinieto avatar Oct 11 '16 03:10 urinieto

The parameters you mention aren't so important for melody extraction. (For ex. the overlap threshold has almost no effect).

If I understand right though, the larger issue you're trying to solve in the example from msaf is the issue of setting parameters for an algorithm like I do manually here, where an experiment might use different settings and compare them for example. I looked through what you do in msaf and I don't totally understand why all of the configs are necessary. What do think it improved over using parameters with a default value?

For now, I think I'll do the the scikit-learn approach, and set the parameters in the init.

rabitt avatar Oct 13 '16 16:10 rabitt