Luka Rahne

Results 23 comments of Luka Rahne

Thank You now it works. Issue with server I was building, boiled down to this, and now when I am running with mutex instead of signal it works ok. Regarding...

Thank for this. I think you are on point. If you can make PR that would be great. My concern is only about backward compatibility.

It is auto derived. So it basically works by cloning internal state. https://docs.rs/rand/latest/src/rand/rngs/small.rs.html#80 Or basically https://docs.rs/rand_xoshiro/latest/src/rand_xoshiro/xoshiro256plusplus.rs.html#22

I am not sure that was intentional. For example current pull request https://github.com/smol-rs/fastrand/pull/38/commits/3e11c107240ae06f58716287462cae84804202c3 still passes same doctest as it was defined in https://github.com/smol-rs/fastrand/blob/master/src/lib.rs#L101-L113 and covers clone() related properties.

I see. Related to split: I think that split Rng should not be correlated with sourced Rng and implementation of split()/fork() should address that.

Let me bump this with suggested improvement to `fork()` Once rng is forked it is expected that output of each generator is uncorrelated with each other. For example if one...

I see your point @cloudhead . It less ergonomic compared to moving tuple around. I guess we have two options. What is your opinion of ~~~ rust fn fork(&self) ->...

@djc in example there is # if you'd like to profile an arbitrary executable: flamegraph [-o my_flamegraph.svg] /path/to/my/binary --my-arg 5 I do not want to post arguments, but path to...

This sound great! Exception vs Error issue is currently addressed by @exaby73 in PR #77 . For this PR it seem that we have breaking change that requires major release....

Thanks for feedback. > Hi, i would also like to see some changes, i'll try to list them here: > > 1. The `_connection` should have the specific type given...