Mykhailo Redko
Mykhailo Redko
On retail WoW classic servers time of sending player's update to out of range group members coincides with heartbeat so I move it's code to `Unit::Heartbeat`.
> Besides this, there is one real issue in this implementation: if the spell has both the procflag AND a proper periodic aura with non-zero period, then this PR will...
This spell has hide-in-combat-log attribute so we are unlikely to see something there.
Default health regeneration stops in combat. With this, I was able to observe health regeneration from spell proc in combat with low-level NPC. Based on the fact that the proc...
> @r4d1sh what is the status of this PR ? Maybe soon I will continue to work on this PR.
Just a side note: Seems like aura from spell "Brittle Bones" (ID: 32441) should proc on heartbeat and trigger spell "Rattled" (ID: 32437) with a certain probability. I don't know...
I'd be grateful if someone could test this. Because I have no idea how to make sure the bug is no longer reproduced.
> > I'd be grateful if someone could test this. Because I have no idea how to make sure the bug is no longer reproduced. > > [#28450 (comment)](https://github.com/TrinityCore/TrinityCore/pull/28450#issuecomment-1328217322) Ok...
> is this PR ready to be merged then ? Yes
> ```sql > -- Use Dash only when in Cat Form > DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=17 AND `SourceGroup`=0 AND `SourceEntry` IN (1850, 9821, 33357); > INSERT INTO `conditions` (`SourceTypeOrReferenceId`,...