Ricardo Mariano

Results 5 comments of Ricardo Mariano

I was looking into this, and noticed that Misk [already configures Jetty to do a graceful shutdown](https://github.com/cashapp/misk/blob/9593078083385e235dda816af539bd48bae616c3/misk/src/main/kotlin/misk/web/jetty/JettyService.kt#L248) ([SO](https://stackoverflow.com/questions/25011249/embedded-jetty-and-graceful-shutdown)). Then, because `JettyService` is in a terminating state, the readiness check also...

Unless we remove MockWebServer, this isn't possible because Misk uses it, and this issue isn't resolved: https://github.com/square/okhttp/issues/4667

Upstream: https://github.com/Kotlin/dokka/issues/1405

Some more logs from the CI build with extra okhttp logging added: ``` INFO: [0 ms] callStart: Request{method=POST, url=https://127.0.0.1:39961/test/GetDestinationWarehouse, headers=[te:trailers, grpc-trace-bin:, grpc-accept-encoding:gzip, grpc-encoding:gzip], tags={class com.squareup.wire.GrpcMethod=com.squareup.wire.GrpcMethod@20376e8d}} INFO: [0 ms] proxySelectStart: https://127.0.0.1:39961/...

Sorry about the long delay in replying. I think that a test on the Injector with different envs should have picked this up. While we've added config-checking via [hoplite](https://github.com/sksamuel/hoplite), that...