Rahil Shah

Results 189 comments of Rahil Shah

With the fix from https://github.com/eclipse-openj9/openj9/pull/15824, I no longer see the same failure on Z. While re-running the test, I am seeing [1] getting failed on Z with following segmentation fault...

Looking at the CopyZipFile.java.CopyZipFile failures on AIX, where we fail with the [this exception](https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/20d13352ee5c9569416880e340d5c589161082f9/test/jdk/java/util/zip/CopyZipFile.java#L182-L183), issue seems to be related to zlib on AIX 7.3 P10 (Or integration JDK with zlib)...

For the `DeflateIn_InflateOut.skipBytes` failure, it is failing because of the incorrect assumption taken by the test case. The test stores the compressed data size in [numReadable](https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/20d13352ee5c9569416880e340d5c589161082f9/test/jdk/java/util/zip/DeflateIn_InflateOut.java#L154-L161) variable for the input...

I have opened up WIP PR in https://github.com/ibmruntimes/openj9-openjdk-jdk11/pull/559 that fixes the `skipBytes` where it resets the data only ones and uses same data for skipping different bytes throughout the test....

Further looked into the failures seen with `tools/pack200/PackTestZip64.java.PackTestZip64` on Z. We fail while comparing two jar files in [1]. Here the first jar file [testFile](https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/20d13352ee5c9569416880e340d5c589161082f9/test/jdk/tools/pack200/PackTestZip64.java#L68-L72) is created with the `--repack`...

The pasted job id does not upload any diagnostic files to inspect. I have launched grinders on internal farm to see if I can get one. 10x Grinder on Same...

@hzongaro No, one with 100x also passes.

I have a strong suspicion that failures on Z are related to this change. Unfortunately I can not tell more as the failure happens while building test and none of...

Failure on Z was 100% reproducible. I looked through the log file and found that when we emit super class test on Z for checkCast node with dynamic cast class,...

@joransiu any concerns/review with this change? Since @dchopra001 have tested the changes with different test case, and the sanity test passes, should we attempt merging this one?