Thorben T.

Results 255 comments of Thorben T.

@alexandergeiler: well, you still didn't post your config. do you also have aggmode: max in there? (to fit mbehr1's theory)

@hydrocontrol: thanks, but it seems both dumps you posted are corrupt. :\ valid sml messages should have a header and footer of three times `0x1b`, which your dumps are clearly...

indeed... in the reading_thread, buffer->aggregate() is called unconditionally: https://github.com/volkszaehler/vzlogger/blob/master/src/threads.cpp#L122 buffer::agregate() only does nothing if_aggmode == NONE: https://github.com/volkszaehler/vzlogger/blob/master/src/Buffer.cpp#L52 if aggmode==MAX, it will calculate the max of the value(s) and DBL_MIN: https://github.com/volkszaehler/vzlogger/blob/master/src/Buffer.cpp#L58...

https://bytes.com/topic/c/answers/216260-most-negative-double-value so it should be `-DBL_MAX`, instead of `DBL_MIN` (and should previouslyh have been `0`, if anything, not DBL_MIN)

it remains an open question if that aggregation mode actually makes sense for negative values. it should probably use the largest absolute value, ignoring the sign. (but return it with...

@J-A-U: i only mentioned you because it seems you authored the wiki entry that claims that setting aggtime to -1 is a safe way to disable aggregations. can you maybe...

should we maybe really disable aggregatiof if aggtime is

this needs testing by somebody who uses a D0 and/or SML meter

@mbehr1: you think this can be merged? it's completely untested so far, so i'd rather wait for some feedback.

(sorted out some changes that were in the wrong commit(s))