Thorben T.

Results 255 comments of Thorben T.

this solves #75 and probably #39 too. (i needed this because i have a device using address 248 ("PZEM-014/016 Energy Meter")

quirks was added in https://github.com/stephane/libmodbus/commit/f0db03dd4816b26cd55432aac820c61eeeccd96b two years ago. if it's desired to support older libmodbus versions, this would have to be made conditional at compile-time.

i gave my reasoning to not make it optional above, i don't think it's worth adding an option. if one did that, one should also catch every possible error case...

your distribution (i have never heard of "Rocky Linux") seems to contain some (broken) logic that tries to automatically install dependencies. it generates an invalid package name, and fails. you...

as to why it's not finding the libmodbus you installed, you gave only very little details. `make install` for libmodus should have installed `libmodbus.pc` to `/usr/lib/pkgconfig/` or similar. you should...

deprecation warnings are not logged by default on debian, ``` $ grep error_reporting /etc/php/8.2/apache2/php.ini ; error_reporting error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT ``` but our code, at the same...

maybe the best fix would be to not mess with `error_reporting` at all and leave it at the system defaults?

this mainly reminds me of https://github.com/volkszaehler/vzlogger/issues/624 @dm82m: can you say why you are not using the debian package? you should be able to just `apt-get install vzlogger`

this seems to be largely redundant with https://github.com/volkszaehler/vzlogger/pull/476 ? :confused: i created https://github.com/volkszaehler/vzlogger/pull/476 four years(!) ago, it never got any further/merged because of open questions that i can't answer myself,...

from my first read,your fix is largely identical to the one in #476 , except for: * you use different terminology. * i questioned if mine is sensible: https://github.com/volkszaehler/vzlogger/pull/476#discussion_r606380911 *...