Rubén Muñoz--Bertrand
Rubén Muñoz--Bertrand
I just did a quick and dirty try with addition, and the `padic_float_nmod` approach seems twice faster.
Looks good to me, and CI failures are unrelated to this fix.
I agree that this would be the best solution. The thing is that, to have something similar to number fields, I believe we would either need to implement extensions of...
Sorry for the delay, I'm on holiday and will be slow to answer in the next weeks (but I will always reply eventually). @user202729 I liked your idea to add...
Failing doctests, please wait until I can fix this.
Ready for review!
Thank you! Indeed having to do these checks is not the best, but by doing the other test we would need to implement `absolute_degree` everywhere, and make sure that every...
Indeed, when I was reviewing this I was afraid about this for the doctests. I wonder if another solution would be to have some keyword (like we do with `#...
Oof! Nice catch! Indeed the Unicode approach seems better here.
Your fix looks good to me. While we're at it, do you know the rationale for `_ = A.rank()` on line 2115 ? I'd guess it's to see that storing...