Qunxin Liu
Qunxin Liu
the result of closure_feature is used in remapping feature indexes. And feature index mapping is needed in subsetting ScriptList->Script->LangSysRecord, where we need replace old feature index with new feature index.
Yes, I think so, I'll work on this.
No, fix is ported in #4484, could you help close the issue? I cannot close it.
> > I cannot close it. > > I now changed your user to "Write", was only "Read" before for some reasons thank you!
Yes, I'll work on it.
Hi, can I get a testcase for this issue?
oh, if we only pin wght to 400, that's partial instancing and not supported yet. I just tried that and got an error in dumping avar table when converting subsetted...
Currently we have "wght=drop" which means pinning to default, I believe this is the same as fonttools. But user still needs to enter [axis name]=drop for each axis
> The BASE table subsetting doesn't seem to be complete. With > > ``` > $ hb-subset --variations=wght=900 Sans/Variable/OTF/NotoSansCJKjp-VF.otf -o Sans/OTF/Japanese/NotoSansCJKjp-Black-instance.otf > ``` > > I still get a VarStore...
I'd like to check with you cause I'm not familiar with vhea/hhea tables: so we only need to update these fields for instancing, not for subsetting, right?