Andrew Walbran

Results 113 comments of Andrew Walbran

Does anybody else want to look through #431 before I merge it?

Thanks for looking at #431! I'm pretty sure there are no breaking changes since 0.16.0; looking at the diff the only API changes are adding new methods and types, so...

@BartMassey I've merged a couple more small PRs and sent #434 to prepare for a 0.16.1 release. Once that's in and published I'll merge #431.

#434 is merged but I don't seem to have permission to publish `nrf-hal-common` to crates.io.

Thanks! I've updated this to work with current master and fixed a bunch of small things. It looks good, except that it doesn't build for nrf51 or nrf52832. Is that...

Thanks! We should probably fix the PAC to add the missing fields, but I'm alright with this for now.

> Thanks for working on this! > > I'm easily confused. Should this trait be named `rtic-monotonic`? Or is it more general than that? Do you mean the feature flag?

Unfortunately I don't have any nRF51 or nRF52832 board either. I've tested it on an nRF52833 and that works at least, and the code looks reasonable to me.

The crash is because `local_ipaddress::get()` returns `None`, presumably because there is no network connection at that point. This is a bit weird, as `mijia-homie` shouldn't be started until the network...

I don't think so currently, but you're welcome to send a PR to add support. Or see #182 for a workaround.