Andrew Walbran

Done.

> Shouldn't `BLOCK_SIZE` be an associated constant? I tried that but unfortunately it doesn't work, as Rust doesn't allow associated constants to be used in the types of trait methods....

Any further comments on this? Can it be merged?

@thejpster What do you think of the current approach of the block size being a const parameter to the trait? I think this is is a decent compromise, as the...

`BlockIdx` and `BlockCount` seem like unneccessary extra complexity to me, but I can add them here if you really want. I do definitely think we should use `u64` for block...

Done, and updated https://github.com/rust-embedded-community/embedded-sdmmc-rs/pull/162 to match.

I've swapped the order of parameters. I'd rather not constrain the error type in the trait, as I've seen a fair few embedded driver crates whose error types don't implement...

Thanks for the review! Can you merge the PR too? The CI failures are all existing issues as far as I can see, not changed by this PR.

Hi there, I'm afraid I haven't yet had a chance to try embassy or chiptool myself. You could try running chiptool on the patched SVD files from this repository and...

I don't think this workaround belongs in `btleplug`, you can keep using an old version via your `Cargo.lock` file.