Tako Schotanus
Tako Schotanus
Sure, I normally have no problems creating PRs, but we're talking about quite a complex piece of software here and you said it would be easy for you :-) But...
Ok, I found out that I can get somewhat further by supplying my own `RequestPatternTransformer` which would additionally set the `hostPattern`. Unfortunately I can't simply pass that to the `SnapshotStubMappingGenerator`...
Another solution would be that we can have an extension point that allows us to insert ourselves in the process of converting `ServeEvents` into `StubMappings` (in `Recorder.serveEventsToStubMappings()`) , possibly by...
Ok, I created a draft PR that specifically fixes this issue, but see my comments on the PR itself because I'm not really happy with my chosen implementation.
One way of doing this would be for JBang to switch to `--add-modules=ALL-DEFAULT` instead of the `ALL_SYSTEM` it uses now. But I'm not really sure what the effect of that...
> Like, if we use ALL-DEFAULT then yes, we dont get the warning, but now you need to list -J--add-modules=jdk.incubator.vector to access it and you still get the warning despite...
Well running `jbang https://github.com/jbangdev/jbang-examples/blob/ae3947cda944f2e354cf65a970d15b97a1084964/examples/turtle/TurtleDemo.java` definitely works :-)
But somehow I would find this even more "impressive": ```java ///usr/bin/env jbang "$0" "$@" ; exit $? //SOURCES https://github.com/NicholasSeward/Turtle/blob/main/Turtle.java import java.awt.Color; public class TurtleDemo { public static void main(String[] args)...
Sure, but it would be nicer to do that upstream, right?
Btw, I just found another one-file library that could be nice for a JBang example: https://github.com/arkanovicz/essential-json/blob/master/src/main/java/com/republicate/json/Json.java it's a JSON parser in a single file (there's also a Maven artifact, but...