qds-sdk-py icon indicating copy to clipboard operation
qds-sdk-py copied to clipboard

Improvement of the Presto Example :

Open JeanLescut opened this issue 5 years ago • 5 comments

  • Simplified a lot the whole script
  • Made everything compatible with Python 3
  • Removed the print() for proper logger
  • Added assert() for parameters sanity checks
  • Allows passing keywords arguments to pd.read_csv()
  • Removed useless dependencies ...

JeanLescut avatar Apr 26 '19 13:04 JeanLescut

If you have any questions on my PR, feel free

JeanLescut avatar Apr 30 '19 14:04 JeanLescut

Hey guys, I have:

  • rebased my fork on the current "unreleased" branch of your repo
  • commited and pushed a new version, with some minor code improvement and a timeout (to answer msumit question

Now, even if Qubole query got stuck, the function still return with error. Feel free to improve it as well.

JeanLescut avatar Jul 29 '19 13:07 JeanLescut

Also, it seems that Travis CI is failing to install Python 3.3 and 2.6 (??) but I don't think it's related to this PR

JeanLescut avatar Jul 29 '19 13:07 JeanLescut

yes @JeanLescut looks like the Ubuntu version was not pinned in our configuration and hence it got updated to 16.XX in which these python versions are not present, will fix it. Thanks for the PR btw

chattarajoy avatar Jul 29 '19 13:07 chattarajoy

@JeanLescut I have fixed the issue, please rebase your branch once more and squash all your commits.

chattarajoy avatar Jul 29 '19 14:07 chattarajoy