Jan Kwakkel
Jan Kwakkel
Can you elaborate on the "other fixes" from the title?
@nissu99 can you give an indication of your timeline? We might otherwise merge some other altair PR first.
This PR is already an improvement. The logical next step, which ideally would be part of this PR, is to structure the code exactly as done for matplotlib. This, for...
Grid visibility is not trivial for networks or hexgrids. Hence, it is included on the matplotlib side and controlled via a boolean. As indicated in #2642, I am considering changing...
Having closed #2588, I looked at the example. This prints ``` 1st case: Run model then display agent_vars dataframe Integer of final model step = 3 Tally from Foo agent...
With 45 files changed, this PR has become impossible to review. I see a lot of value in adding this, however, would it be possible to have only this one...
My bad, I had not carefully checked the PR. It is not 45 files _changed_, but 1 file changed (pre-commit) and 44 new files required for vale. Can you briefly...
Finally had time to look closer at Vale. It seems [they suggest](https://github.com/errata-ai/vale-action) to put the `styles` and `.vale` folders inside the `.github` folder. Can you ensure the layout follows their...
I think this looks good, but it would be good if one of the other maintainers also takes a look.
Some quick updates of what needs doing: 1. rename make_space_altair to something like make_altair_space_component 2. add make_altair_plot_component 3. Add support for all spaces. This means including the hexgrid and network...