Jan Kwakkel comments

Results 545 comments of


                                            Jan Kwakkel

Add `create_agent` factory method to Agent

done

Add `create_agent` factory method to Agent

> What might be really useful if it returns a convenient AgentSet with the just created Agents. I have been going back and forth on this. It's easy to add...

Add `create_agent` factory method to Agent

just added it

All functions with @solara.component annotation missing on read the docs

My hunch is that the wrapper in `solara.component` should itself be annoted with [`functools.wraps`](https://docs.python.org/3/library/functools.html#functools.wraps) to solve this problem. According to the docs "_Without the use of this decorator factory, the...

All functions with @solara.component annotation missing on read the docs

In my understanding it's an upstream problem in Solara, so there is little we can do in MESA itself to fix the issue.

Using DEVSimulator: How to prevent simulation from stopping when no events are present?

If there is no next event scheduled, there is nothing the DEVS scheduler can advance to. This is the definition of the next event time progression and conforms to all...

Using DEVSimulator: How to prevent simulation from stopping when no events are present?

You don't need to change anything inside mesa for this. Just schedule an event for the current time step with a while loop: ```python while self.model.simulator.eventlist.is_empty(): time.sleep(0.1) ```

Adds Altair plot component and some other fixes

Removing stuff that has become redundant is fine.

Adds Altair plot component and some other fixes

I'll try to review it over the weekend, but I am rather bussy at the moment. This is a part of the code base I am not intimately familiar with...

Adds Altair plot component and some other fixes

I suggest we try to merge this PR first, then rebase #2643 and merge that afterward. @nissu99, @sanika-n do you both agree? My motivation is that this overhauls the structure...