qualisys_cpp_sdk
qualisys_cpp_sdk copied to clipboard
Fix installation paths.
GNUInstallDirs was not defined when target_include_directories was set. This caused it to be blank and the cmake target import failed. User projects importing the cmake target should use include qualisys_cpp_sdk/RTProtocol.h etc.
I confirm this is required on your Nvidia jetson platforms. @Capelliexp
I did this PR before I saw your @jgoppert . I believe this simple change fix your issue as well: https://github.com/qualisys/qualisys_cpp_sdk/pull/45
Like @MaximilienNaveau pointed out, his approach in #45 also addresses this issue by hardcoding include as the install path. However, I think using include(GNUInstallDirs) to set CMAKE_INSTALL_INCLUDEDIR provides more flexibility by allowing the path to adapt to system-specific conventions.
If there are any additional insights I should be aware of, please let me know. (:
Like @MaximilienNaveau pointed out, his approach in #45 also addresses this issue by hardcoding
includeas the install path. However, I think usinginclude(GNUInstallDirs)to setCMAKE_INSTALL_INCLUDEDIRprovides more flexibility by allowing the path to adapt to system-specific conventions.If there are any additional insights I should be aware of, please let me know. (:
I believe this PR is better suited to be merge than mine I closed mine in response
@jgoppert : could you consider adding https://github.com/nim65s/qualisys_cpp_sdk/commit/1ba8cdb9a8e3583b68d93a553a6f59ea7ee24876 to this PR ? Otherwise I could make another one, but it is built on yours, so I guess it would be cleaner.
Hey! I just wanted to mention that we've taken these changes from this fork of yours and create THIS PR. Feel free to have a look at it. Note that the "sprintf" issues have already been fixed.
Once the PR is approved and merged then we can close this one. Thank you very much for the input. :)
I simplified this PR and just make the GNUInstallDirs fix.
@OliverGlandberger @nim65s maybe we can make the other changes another PR and close this one for simplicity?
If it makes more sense to take it all together with https://github.com/qualisys/qualisys_cpp_sdk/pull/65 I'm fine with that. Just happy to see it merged :-)