qualisys_cpp_sdk icon indicating copy to clipboard operation
qualisys_cpp_sdk copied to clipboard

Fix installation paths.

Open jgoppert opened this issue 2 years ago • 1 comments

GNUInstallDirs was not defined when target_include_directories was set. This caused it to be blank and the cmake target import failed. User projects importing the cmake target should use include qualisys_cpp_sdk/RTProtocol.h etc.

jgoppert avatar Feb 22 '23 15:02 jgoppert

I confirm this is required on your Nvidia jetson platforms. @Capelliexp

gorghino avatar Jun 13 '23 06:06 gorghino

I did this PR before I saw your @jgoppert . I believe this simple change fix your issue as well: https://github.com/qualisys/qualisys_cpp_sdk/pull/45

MaximilienNaveau avatar Nov 05 '24 10:11 MaximilienNaveau

Like @MaximilienNaveau pointed out, his approach in #45 also addresses this issue by hardcoding include as the install path. However, I think using include(GNUInstallDirs) to set CMAKE_INSTALL_INCLUDEDIR provides more flexibility by allowing the path to adapt to system-specific conventions.

If there are any additional insights I should be aware of, please let me know. (:

OliverGlandberger avatar Nov 07 '24 11:11 OliverGlandberger

Like @MaximilienNaveau pointed out, his approach in #45 also addresses this issue by hardcoding include as the install path. However, I think using include(GNUInstallDirs) to set CMAKE_INSTALL_INCLUDEDIR provides more flexibility by allowing the path to adapt to system-specific conventions.

If there are any additional insights I should be aware of, please let me know. (:

I believe this PR is better suited to be merge than mine I closed mine in response

MaximilienNaveau avatar Nov 07 '24 13:11 MaximilienNaveau

@jgoppert : could you consider adding https://github.com/nim65s/qualisys_cpp_sdk/commit/1ba8cdb9a8e3583b68d93a553a6f59ea7ee24876 to this PR ? Otherwise I could make another one, but it is built on yours, so I guess it would be cleaner.

nim65s avatar Nov 07 '24 15:11 nim65s

Hey! I just wanted to mention that we've taken these changes from this fork of yours and create THIS PR. Feel free to have a look at it. Note that the "sprintf" issues have already been fixed.

Once the PR is approved and merged then we can close this one. Thank you very much for the input. :)

OliverGlandberger avatar Feb 19 '25 14:02 OliverGlandberger

I simplified this PR and just make the GNUInstallDirs fix.

jgoppert avatar Feb 19 '25 18:02 jgoppert

@OliverGlandberger @nim65s maybe we can make the other changes another PR and close this one for simplicity?

jgoppert avatar Feb 19 '25 19:02 jgoppert

If it makes more sense to take it all together with https://github.com/qualisys/qualisys_cpp_sdk/pull/65 I'm fine with that. Just happy to see it merged :-)

jgoppert avatar Feb 19 '25 19:02 jgoppert