Quentin Monnet

It could be interesting to add the following change as an additional commit to your PR: ```diff diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 60eefc28d727..a11391c430ca 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -17,10...

The tests pass correctly this time :tada:, but we get warnings about `cargo-clippy`. I'm not sure why, maybe using `--no-default-features` disables something clippy-related. I'll take a look later.

Thanks a lot! Sorry I didn't have the time to review last night, I'll do it soon.

Congrats on getting your µBPF paper into the ACM workshop! :tada:

Hi, sorry I'm not sure what you mean. Do you mean applying the token bucket to just a given IP address, or do you mean applying it to all IPs...

So you would have to filter on IP addresses, see how [we get the source IP](https://github.com/qmonnet/tbpoc-bpf/blob/master/tokenbucket.c#L115) already. Compare the first three bytes of your IPs with the network prefixes you...

No sorry, I don't have time at the moment. You'll have to do your homework :)

@h3llix You can either take another [good first issue](https://github.com/cilium/cilium/labels/good-first-issue), or dig through the list of [unassigned issues](https://github.com/cilium/cilium/issues?q=is%3Aissue+is%3Aopen+no%3Aassignee+no%3A+-label%3Aci%2Fflake+). Are you looking to contribute on some particular component/feature?

Oh, I hadn't noticed that you were involved here. Good, more ties than I thought, then :) OK, SBF as a name makes sense to me in that case. That's...

Hi there, implementing this on one of our smartNICs seems completely doable to us (/Cc @edwin-peer @kuba-moo). Apparently we have some firmware code not too far from this, but I...