Results 37 comments of Qi Zhou

See https://github.com/ChainAgnostic/CAIPs/pull/125

> The following is a change I feel needs to be made: > > 1. For `IERC721NOA`, **specify what happens when someone calls `ownerOf` on a `tokenId` that is owned...

> Would you mind also rebasing on top of `master`? The GitHub workflow file in this branch is out of date (and is missing some checks.) Done. Thanks for the...

> The following is a change I feel needs to be made: > > 1. For `IERC721NOA`, **specify what happens when someone calls `ownerOf` on a `tokenId` that is owned...

> Couple other notes I can't directly comment on: > > * Since a NOA is a contract, technically its a subtype of a contract account (as opposed to alongside...

Many thanks for the comments @Pandapip1 . We are working on some issues found by the draft, and we will update a final one for review shortly.

> @qizhou please resolve the merge conflicts Thank you. Rebasing with some latest changes.

After discussing with the team, we will withdraw the version from "review" since there are a couple of major concerns. We are focusing on polishing EIP-4972 and will create another...

I strongly support @MicahZoltu 's proposal of removing censorship, but I agree with @JFrankfurt that this will put uniswap at high risk. In fact, as long as we are living...

The for-loop in the resolveClaim() may have a similar issue https://github.com/ethereum-optimism/optimism/blob/546fb2c7a5796b7fe50b0b7edc7666d3bd281d6f/packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol#L394 (although with bond, such attack will be much more expensive)