Update eip-4972.md

[qizhou]

Change status from draft to review

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

• The PR edits only existing draft PRs.
• The build passes.
• Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
• If matching on email address, the email address is the one publicly listed on your GitHub profile.

[eth-bot]

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

---

(fail) eip-4972.md

classification
statusChange

• eip-4972 state was changed from draft to review
• This PR requires review from one of [@lightclient, @axic, @samwilsn, @pandapip1]

[qizhou]

The following is a change I feel needs to be made:

1. For IERC721NOA, specify what happens when someone calls ownerOf on a tokenId that is owned by an NOA. Should it throw? Return the zero address? This is ambiguous right now.

Here are some suggestions for other changes that I feel the standard is lacking:

2. Add methods to IERC721NOA and IERC20NOA that allow users to transfer tokens to NOAs, and get the balance of NOAs.
3. Add an NOA extension for EIP-1155. This is slightly less commonly used as EIP-721, but is common enough that it deserves to be included IMO.

Many thanks for the comments. We are working on the comments and will update the PR shortly.

[SamWilsn]

Would you mind also rebasing on top of master? The GitHub workflow file in this branch is out of date (and is missing some checks.)

[qizhou]

Would you mind also rebasing on top of master? The GitHub workflow file in this branch is out of date (and is missing some checks.)

Done. Thanks for the suggestion.

[Pandapip1]

The eipw errors need to be fixed.

[qizhou]

The following is a change I feel needs to be made:

1. For IERC721NOA, specify what happens when someone calls ownerOf on a tokenId that is owned by an NOA. Should it throw? Return the zero address? This is ambiguous right now.

Thanks for the comment. The ownerOf method will return a name-derived address (NDA, also 20 bytes EH address). The NDA can be obtained by calling addressOfName method.

Here are some suggestions for other changes that I feel the standard is lacking:

2. Add methods to IERC721NOA and IERC20NOA that allow users to transfer tokens to NOAs, and get the balance of NOAs.

Thanks for the comment. Currently, it can be done by transferring tokens to NDAs (and getting the balances from the NDAs)

3. Add an NOA extension for EIP-1155. This is slightly less commonly used as EIP-721, but is common enough that it deserves to be included IMO. Thanks for the comment. The extension for EIP-11155 is added. Please take a look.

[github-actions[bot]]

The commit 795b069b4ccc0b1450035d306c25559cca2904bc (as a parent of 213ef960cfc1904a197064a2e249fc96af08e0c3) contains errors. Please inspect the Run Summary for details.

[github-actions[bot]]

The commit 7d4e75aa0305df11dd60e6d93c7a4e8ec3ae19bc (as a parent of 213ef960cfc1904a197064a2e249fc96af08e0c3) contains errors. Please inspect the Run Summary for details.

[github-actions[bot]]

The commit c452423f48b6403e27d9af19e3228ce888403e8e (as a parent of 8cd007d87c4623e99ce31cea3bec94ded8a5f732) contains errors. Please inspect the Run Summary for details.

[github-actions[bot]]

The commit a900c24ff5b78071b09e35684d701dd4327cea99 (as a parent of 5be808126b01257d07f333eea6ac89dc580c5bb2) contains errors. Please inspect the Run Summary for details.

[github-actions[bot]]

The commit 0d29b6e471fa1d3d7000a45a548c513726adf057 (as a parent of 083c15f6f09c196907ac6d055bf2c77b69882373) contains errors. Please inspect the Run Summary for details.

[qizhou]

Couple other notes I can't directly comment on:

• Since a NOA is a contract, technically its a subtype of a contract account (as opposed to alongside as specified in the abstract.)

Thanks for the comment. The NOA is not a contract, but an account, whose owner is managed by a name service. Further, we use address(nameStringWithNSSuffix) as the name-derived address so that we can lookup the operators/owners of the address. Note that the address cannot be directly used by an external account or a contract in Ethereum - it can be only used by operators (as managed NS) via transferFrom type of transactions. Hope this can explain it. Please let me know if you have further comments!

[qizhou]

Many thanks for the comments @Pandapip1 . We are working on some issues found by the draft, and we will update a final one for review shortly.

[github-actions[bot]]

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

[Pandapip1]

@qizhou please resolve the merge conflicts

[qizhou]

@qizhou please resolve the merge conflicts

Thank you. Rebasing with some latest changes.

[qizhou]

After discussing with the team, we will withdraw the version from "review" since there are a couple of major concerns. We are focusing on polishing EIP-4972 and will create another PR once it is ready. Many thanks for the comments and suggestions @Pandapip1 @SamWilsn @xinbenlv