Yijie Qin
Yijie Qin
@roidelapluie @gotjosh Based on our previous discussion, Wonder if we have a chance to test this out? Thanks a lot for the help!
> The code could use [`strings.ToValidUTF8`](https://pkg.go.dev/strings#ToValidUTF8) to eliminate invalid UTF-8 byte sequence rather than dropping everything. Thanks for the comment! I wonder which will be better in case of user...
Hi Josh @gotjosh. Thanks a lot for your comments. The main problem that we are trying to solve is to identify the notification failure from customer input failure (for eg:...
Hi after enable the ReplicationFactor of ruler to more than 1 We found the problem is from the ALERTS_FOR_STATE metrics, because of each rulers' activeAt can be different, We get...
@gotjosh @simonpasquier Could you take a look at this as well tysm!
Thanks @roidelapluie for your comments. I wonder if everybody is okay with current approach, can i get approved for this PR? Thank you so much Yijie
### API change We will add two optional parameter for limit and startToken, limit for how many rule groups to paginate, and startToken will be the token refer to where...
Pagination is important as prometheus is also used for other open source project such as cortex that is designed for multi-tenant environment. The lack of support of the pagination cause...
For my opinion it is a better user experience to truncate the alerts rather than drop the whole thing when the limit got hit. Image when i hit the limit...