YQ Tsui

Results 13 comments of YQ Tsui

@you-n-g Would you take a look please? Let me know if anything needs improvement. Thanks!

Thanks for reply. Updated as you suggested. Also corrected some wrong param list comments.

@you-n-g any feedback please?

@you-n-g It's because the base 'microsoft:main' on Aug 13, which was the base of my pull request, had failed CI . Fixed after merging the latest 'microsoft:main'.

@you-n-g took a further look on the failure it complains ``` self = Rolling [window=10,min_periods=1,center=False,axis=0,method=single] attr = 'rank' def __getattr__(self, attr: str): if attr in self._internal_names_set: return object.__getattribute__(self, attr) if...

@you-n-g Dig in some further, it looks the py3.7 tests fails because `Rolling.rank` was added from pandas 1.4.0+ but py3.7 can only run pandas up to 1.3.5. So the failures....

@you-n-g any thoughts please?

I don't think this can be fixed without using a proxy. And this time we cannot even blame GFW. If you visit https://finance.yahoo.com/ with your browser, this will be what...

@you-n-g any progress please?

@you-n-g any comments on this?