Caleb Hoff

Results 15 comments of Caleb Hoff

Apologies for not noticing the commitlint requirements sooner. I am developing on Windows, so the .sh files didn't execute, preventing me from being warned about commit message formatting.

In my next PR, I plan to: 1. Remove web-vitals. It's built into modern browsers anyway, so it seems pointless. I personally think it would make more sense to leave...

@Can-Sahin I hope you enjoyed your vacation! When you get a chance, could you take a look at this PR? I have a few more things I'd like to do...

yes it does. should the editor not auto format? i love this feature

It's nice that the other pull request is in. I had been excited to transition to Yarn v3, but I felt like it should happen after. Next, I plan to...

> One question. Does yarn v3 affect the template in any way? I mean people using different yarn versions wouldn't see any difference right? this is actually the coolest part...

> Don't you need `.yarnrc.yml` included in the template? Otherwise, how does it know which plugins to include? yes, it will need to be included. this file tells yarn where...

> Then you need to modify this file as well otherwise template folder will not have it inside > > https://github.com/react-boilerplate/react-boilerplate-cra-template/blob/master/internals/scripts/create-template-folder.ts ah right. good call. I forgot to do this....

> What do you mean by nested workspaces? This isn't a monorepo yarn 2+ does not like executing in a folder where any of its parents have a yarn.lock. I...