Afri
Afri
Looks good to me, can you update the branches to the latest head on main? That should make the entire CI green now.
Thank you @unbanksy - your comments were spot on. I cannot edit this branch, so I took over in >> #185
I would love to redo the RLP and ABI parts of this gem (time permitting). I'm interested in collaborating. I'll take a look at your gem collection after the holidays....
> Thanks for the response - you can find a first version of a new RLP gem (called rlp-lite) at https://github.com/rubycocos/blockchain/tree/master/rlp-lite - this is actually a fully functional and quick...
reference for tuple encoding: https://github.com/ethers-io/ethers.js/blob/c80fcddf50a9023486e9f9acb1848aba4c19f7b6/packages/abi/src.ts/coders/tuple.ts ruby: https://github.com/rubycocos/blockchain/blob/53edc7ba0f776bcd2f1531ce1445be1adac5dabc/abicoder/lib/abicoder/encoder.rb#L118 (I might look into porting this over) I'll probably get the tests from ethers.js or web3.js
Solution would be to find a Ruby engineer who has time 😆
@geraldb I ported your collection of spec tests to this gem and identified two different issues - we cannot encode tuples (obviously, this issue) - we cannot encode multi-dimensional arrays...
Are you currently working on this @kurotaky ?
> **EncodePacked** Yes, `encodePacked` performs packed encoding where: > > * Dynamic types are encoded in place without length. > * Static types will not be padded if they are...
