Afri

Results 175 comments of Afri

Ok got it. Can you take a look? I implemented custom solidity errors (if data is present), like the following: ``` /home/user/.src/q9f/eth.rb/lib/eth/client.rb:493:in `send_command': {"jsonrpc"=>"2.0", "id"=>1, "error"=>{"code"=>3, "message"=>"execution reverted", "data"=>"0x7e2732890000000000000000000000000000000000000000000000000000000000000001"}} (Eth::Client::CustomSolidityError)...

Ok, got it. I just read the documentation. > The compiler includes all errors that a contract can emit in the contract's [ABI-JSON](https://docs.soliditylang.org/en/latest/abi-spec.html?color=light#json). Note that this will not include errors...

Is there a specification on custom errors in ABI? `contract.abi.last["name"]` does not seem to be a safe accessor for that.

Ok, so this library is almost 10 years old. While most of the code has been rewritten over time, some of the _weird_ logic remains. You correctly pointed out that...