Piotrek Żygieło

Given it was not vetoed for few weeks - may I ask to have it merged, please?

> one landmine to watch out for is that JDK's immutable collections can't contain null. https://bugs.openjdk.org/browse/JDK-8265905

Still see this in https://ci.eclipse.org/glassfish/job/glassfish_build-and-test-using-jenkinsfile/job/master/1643/ ``` [2025-01-21T09:18:02.632Z] [artifact:mvn] [INFO] ------------------------------------------------------------------------ [2025-01-21T09:18:02.632Z] [artifact:mvn] [INFO] Reactor Summary for Programmatic authentication with Jakarta Authorization api 7.0.22-SNAPSHOT: [2025-01-21T09:18:02.632Z] [artifact:mvn] [INFO] [2025-01-21T09:18:02.632Z] [artifact:mvn] [INFO] Programmatic...

Assuming non-null wass passed to https://github.com/eclipse-ee4j/glassfish/blob/f7687e86c1f20682f6218067b1e96d76a1d16e3b/appserver/jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/spi/ManagedConnectionImpl.java#L166 the only other assignment in this class I see is https://github.com/eclipse-ee4j/glassfish/blob/f7687e86c1f20682f6218067b1e96d76a1d16e3b/appserver/jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/spi/ManagedConnectionImpl.java#L372 (Unfortunately https://github.com/eclipse-ee4j/glassfish/blob/f7687e86c1f20682f6218067b1e96d76a1d16e3b/appserver/jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/spi/ManagedConnectionImpl.java#L91 but I can't locate any other sub-class.) But given that, could...

Just for clarification - the current master causes NPEx in 669 https://github.com/eclipse-ee4j/glassfish/blob/f7687e86c1f20682f6218067b1e96d76a1d16e3b/appserver/jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/spi/ManagedConnectionImpl.java#L665-L680 ``` at com.sun.gjc.spi.ManagedConnectionImpl.getActualConnection(ManagedConnectionImpl.java:669) ``` not as originally reported `ManagedConnectionImpl.java:680`.

> The libpam is packaged by maven bundle plugin which already supports reproducible builds, so it sets these timestamps to zero. Just to clarify the value of "zero": https://bnd.bndtools.org/releases/6.1.0/instructions/reproducible.html >...

1. DTDs are distributed with glassfish. 2. ``` $ ./bin/asadmin version Version string could not be obtained from Server [localhost:4848]. (Turn debugging on e.g. by setting AS_DEBUG=true in your environment,...

Will it be merged to 8.0? Currently - for admin-cli.jar we distribute: - `7.0: glassfish7/glassfish/modules/admin-cli.jar` - `7.1: glassfish7/glassfish/admin-cli.jar` - `8.0: glassfish8/glassfish/modules/admin-cli.jar` I find this at least unfortunate.

> * Executable JAR (`admin-cli.jar`) I'm getting ``` $ java -jar glassfish7/glassfish/admin-cli.jar Error: Unable to initialize main class com.sun.enterprise.admin.cli.AdminMain Caused by: java.lang.NoClassDefFoundError: org/glassfish/api/admin/CommandValidationException ``` The manifest defines `Main-Class`, but no...

I'm getting ``` $ java -jar glassfish7/glassfish/appserver-cli.jar Error: Could not find or load main class org.glassfish.admin.cli.AsadminMain Caused by: java.lang.NoClassDefFoundError: com/sun/enterprise/admin/cli/AdminMain ``` The manifest defines `Main-Class`, but no `Class-Path`.