glassfish icon indicating copy to clipboard operation
glassfish copied to clipboard

All Modify datetime of files in libpam4j.jar are "1980-02-01 00:00"

Open zsuiqiang opened this issue 2 years ago • 5 comments

Environment Details

  • GlassFish Version (and build number):7.0.8
  • JDK version:17
  • OS:windows 11
  • Database:

Problem Description

All Modify datetime of files in libpam4j.jar are "1980-02-01 00:00"

zsuiqiang avatar Sep 07 '23 01:09 zsuiqiang

I can confirm that, despite I don't see it as an issue I would like to know the explanation :-) It seems it is the target now - reproducible builds, we already have several PRs waiting here. The libpam is packaged by maven bundle plugin which already supports reproducible builds, so it sets these timestamps to zero.

https://maven.apache.org/guides/mini/guide-reproducible-builds.html https://github.com/FasterXML/jackson-databind/issues/3680 - this would be a workaround, the question is what we really want (originally I was against these changes, but I was convinced).

dmatej avatar Sep 07 '23 12:09 dmatej

This causes JNA to be unavailable。See Custom JNA Library Version Support #24358

zsuiqiang avatar Sep 11 '23 08:09 zsuiqiang

This causes JNA to be unavailable。See Custom JNA Library Version Support #24358

I doubt it is caused by this - GF doesn't use file creation/update dates at all. It must be something else.

dmatej avatar Sep 11 '23 11:09 dmatej

The libpam is packaged by maven bundle plugin which already supports reproducible builds, so it sets these timestamps to zero.

Just to clarify the value of "zero": https://bnd.bndtools.org/releases/6.1.0/instructions/reproducible.html

FasterXML/jackson-databind#3680 this would be a workaround,

the question is what we really want

The reproducer I guess. Otherwise I see no issue against GF reported here.

pzygielo avatar Sep 11 '23 17:09 pzygielo

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

github-actions[bot] avatar Sep 11 '24 00:09 github-actions[bot]

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

github-actions[bot] avatar Sep 12 '25 00:09 github-actions[bot]