Jerry Wu
Jerry Wu
It looks like the major cases we want to support now are `mhlo.torch_index_select`, `tosa.gather`, and `tosa.table`. All of them are lowered into the generic op like: ```mlir linalg.generic {indexing_maps =...
Thanks for the suggestions! @dcaballe So from my understanding on the MLIR ops, there are two types of gather ops: - Select slices on a specified dim - [tosa.gather](https://mlir.llvm.org/docs/Dialects/TOSA/#tosagather-mlirtosagatherop) -...
I think we are pretty aligned, thanks for all the comments : ) @MaheshRavishankar pointed out an interesting way. For `tensor.extract` on an n-D table, we can peel outer dims...
I see. So IIUC, right now it's fine to start working on the 1-D case of `tensor.extract`, as it only requires the 1-D `vector.gather`. This can vectorize the `tosa.table` and...
So can we close this issue since it's marked as Done?
> I think the distinction has been that `build_tools/benchmarks` is all the infra related to the benchmarks and `benchmarks/` is for the actual definition of the benchmarks. Kind of like...
After the discussion, I was playing around some ways to make the executable scripts including the utilities directory in the search path. It works but not very elegant. Maybe there...
Sent out #10065 and see how other people think about it 🙂
I think we can separate this PR from #10065. We put the code under `build_tools/benchmarks` for now and move to the new place once #10065 is resolved.
For the trailers, I'm wondering if we can use only `ci-enable` and `ci-skip`. So 1. If there is no trailer, we run the default set 2. If `ci-enable` is present,...