Peter Zich

Results 22 comments of Peter Zich

Excellent! Any chance that future release will also support reversing paths ( #80 ) for greater optimization? 🙏

Hey! Just started using this library last night and ran into the same thing. Any chance it can get fixed?

> Please update this PR to use the files from the new release https://github.com/esphome/esphome-webserver/releases/tag/20240418-041055 Done! > This is because all header files are automatically includes into a generated file named...

Let me know if there are any other changes you'd like or if this is good to merge.

> Long shot here, but is this potentially related to the `INDEX_GZ` changes we dropped from the v3 revision? I think it's sort of related. Essentially currently (before this PR)...

> It could pay to also add `#ifdef USE_WEBSERVER_LOCAL` into the generated headers which would solve this problem entirely. I just added this here https://github.com/esphome/esphome-webserver/pull/89 Let me know if that...

Actually I just realized you're referring to the generated `esphome.h`… I'm not sure if `USE_WEBSERVER_VERSION` still ends up with a value if `USE_WEBSERVER_LOCAL` is not set, but might be worth...

Aha, based on https://github.com/esphome/esphome/blob/2fa58468939b1319b072f7fc3f123dcc1f916605/esphome/components/web_server/__init__.py#L72 and https://github.com/esphome/esphome/blob/2fa58468939b1319b072f7fc3f123dcc1f916605/esphome/components/web_server/__init__.py#L147-L159 it looks like `USE_WEBSERVER_VERSION` always gets added, defaulting to 2.

Rebased this on latest `dev`. Let me know if there are any other changes needed