Peter Gulyas

Results 25 comments of Peter Gulyas

I have no more open issues with this PR, so removing the not-for-unstable label. Now waiting for the conceptual review by @twpol and @cjakeman .

Hi Chris @cjakeman, Yes two of my PRs (this and #538) conflict with each other, and whichever gets merged first into the master, the other will have a conflict that...

Conflict resolved, back on track.

Could you please double-check if you really mount the zip containing the MT_Common.cabs to the right mount point? Vfs.FileExists() flattens the above path to "/MSTS/TRAINS/TRAINSET/MT_COMMON.CABS/HP/CLASS26/CLASS26.CVF" virtual file path, so it...

Are you using the version later than the commit efffead3c1179acbb58d921675fff69c189334f0 ? I've added that specifically to flatten such paths to avoid browsing the imaginary directories, like probably the "CABVIEW" in...

Hi Chris, @cjakeman, My bad, I should have thought of testing it with our own test asset. :-) However on my part everything works well. Now I think your vfs...

No problem Chris, glad you sorted this out!

Quite a big change: I modified the code to use the dotnet builtin ZipArchive class to handle the zip format archives, while leaving SharpCompress to handle the others (rar). (BTW...

Hi Chris, The AppVeyor builds it correctly, and the problem is only on the other server, so I need to go with trial-and-error method, which is impossible if the not-for-unstable...

Hi Chris, Thank you guys for doing the review of my PR. I think this is too fundamental – with taking over almost all file reads as a layer of...